----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/#review128764 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/v1/scheduler.hpp (line 62) <https://reviews.apache.org/r/46116/#comment192227> Can you add a comment here mentioning what happens if Credential is some? - Vinod Kone On April 12, 2016, 10:26 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46116/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 10:26 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4459 > https://issues.apache.org/jira/browse/MESOS-4459 > > > Repository: mesos > > > Description > ------- > > This change adds basic scheme AuthN support to the library. > It would be good to add support for additional schemes in the > future. > > > Diffs > ----- > > include/mesos/v1/scheduler.hpp 6603075fe187ac7d1b56381ffc6e18f14adbfb5a > src/scheduler/scheduler.cpp f9d54f99f3086a8a4349abd3892413fa6bd44437 > > Diff: https://reviews.apache.org/r/46116/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
