> On April 13, 2016, 11:25 p.m., Vinod Kone wrote:
> > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise
> > LGTM.
It looks like it's failing on this step:
```
make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src'
cp /mesos/mesos-0.29.0/_inst/etc/mesos/mesos-agent-env.sh.template \
/mesos/mesos-0.29.0/_inst/etc/mesos/mesos-slave-env.sh.template
cp: cannot stat
'/mesos/mesos-0.29.0/_inst/etc/mesos/mesos-agent-env.sh.template': No such file
or directory
make[5]: *** [copy-agent-env-template] Error 1
```
which is something added in https://reviews.apache.org/r/45806/
The rule is written as:
```
copy-agent-env-template:
cp $(pkgsysconfdir)/mesos-agent-env.sh.template \
$(pkgsysconfdir)/mesos-slave-env.sh.template
```
so somehow during this installation, `mesos-agent-env.sh.template` didn't get
installed correctly before this rule ran. Looking a few lines above this error,
we see that it actually got installed to
`'/tmp/am-dc-13087//mesos/mesos-0.29.0/_inst/etc/mesos`:
```
/usr/bin/install -c -m 644 ../../src/deploy/mesos-agent-env.sh.template
../../src/deploy/mesos-deploy-env.sh.template
../../src/deploy/mesos-master-env.sh.template
'/tmp/am-dc-13087//mesos/mesos-0.29.0/_inst/etc/mesos'.
```
Which I'm guessing is `$(DESTDIR)/$(pkgsysconfdir)`. Looks like we need to
update the rule for `copy-agent-env-template` accordingly.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46134/#review128798
-----------------------------------------------------------
On April 13, 2016, 3:57 a.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46134/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 3:57 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#mesos-3782]
> In this patch, we did the following change:
> 1. Change the libprocess cmake target to use 'mesos-agent'
> instead of 'mesos-slave'
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
> 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652
>
> Diff: https://reviews.apache.org/r/46134/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>
