> On April 13, 2016, 11:22 p.m., Vinod Kone wrote:
> > Ship It!

Don't commit this yet, pert the comment at the botoom of: 
https://reviews.apache.org/r/46134/


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/#review128796
-----------------------------------------------------------


On April 13, 2016, 2:57 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45806/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 2:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-3782
>     https://issues.apache.org/jira/browse/MESOS-3782
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [#mesos-3782]
> In this patch, we did the following changes:
> 1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
> 2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
> to use term 'agent' instead of term 'slave'
> 3. Change the content of ths scripts to use term 'agent' instead
> of term 'slave'
> 4. Duplicate the renamed scripts renamed in #2 during the configure
> and make process, the duplicated scripts still use term 'slave'
> in their names.
> 
> Please note that afull bootstrap is required once this patch has
> been applied. Otherwise, configure will break because of the
> missing mesos-slave-*.sh scripts. Please follow the steps to
> re-build the project:
> 
> ```
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> ```
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 02b6094a6d4c096d7bee3bae294469fd8942998f 
>   bin/gdb-mesos-slave.sh.in dbeec8464b26bd808f7a50b8412a2778f1458f22 
>   bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 
>   bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
>   bin/mesos-slave-flags.sh.in  
>   bin/mesos-slave.sh.in 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
>   bin/valgrind-mesos-slave.sh.in 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 
>   configure.ac 4392909873e588b93e435d260276b0f1b0814c08 
>   src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
>   src/deploy/mesos-deploy-env.sh.template 
> bea5584fbcc68825b1c35b370aed17b0e432edd5 
>   src/deploy/mesos-slave-env.sh.template 
> 31567d6a47e19385aed56edfc7e67457c8cdde3e 
>   src/deploy/mesos-start-cluster.sh.in 
> f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
>   src/deploy/mesos-start-slaves.sh.in 
> 50860f40e33fcbb1787be6c035873de4bcc83de5 
>   src/deploy/mesos-stop-cluster.sh.in 
> e5f8c1fb400c56715774889632aa74d9eac33645 
>   src/deploy/mesos-stop-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 
>   src/slave/containerizer/mesos/launch.cpp 
> 54079c37143f4b5c22e0c9a8fe4bacb31f60ed1b 
>   src/tests/balloon_framework_test.sh 
> ae32753e8942f77f94752543c384d218d6e4d48d 
>   support/generate-endpoint-help.py 5d23b10f0bab9c0e5848c0c1c26855522cf44a70 
>   support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf 
> 
> Diff: https://reviews.apache.org/r/45806/diff/
> 
> 
> Testing
> -------
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Reply via email to