> On April 13, 2016, 11 p.m., Ben Mahler wrote: > > src/examples/test_hook_module.cpp, line 197 > > <https://reviews.apache.org/r/46175/diff/1/?file=1343465#file1343465line197> > > > > Mind committing this as a separate patch?
Done. > On April 13, 2016, 11 p.m., Ben Mahler wrote: > > src/tests/hook_tests.cpp, line 806 > > <https://reviews.apache.org/r/46175/diff/1/?file=1343466#file1343466line806> > > > > How about the following to make the sandbox from > > TemporaryDirectoryTest::sandbox usage more explicit? > > > > ``` > > const string file = path::join(sandbox.get(), "post_fetch_hook"); > > ``` Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46175/#review128783 ----------------------------------------------------------- On April 13, 2016, 10:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46175/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 10:33 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5209 > https://issues.apache.org/jira/browse/MESOS-5209 > > > Repository: mesos > > > Description > ------- > > Added a test for slavePostFetchHook. > > > Diffs > ----- > > src/examples/test_hook_module.cpp 3ff9fd71c275fd1a705ab3aca7a8041f29289bb0 > src/tests/hook_tests.cpp 97ff55ac7ec875b5ba5d4f17d80646c2d1dd4142 > > Diff: https://reviews.apache.org/r/46175/diff/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh > --gtest_filter=*ROOT_DOCKER_VerifySlavePostFetchHook* ` > > > Thanks, > > Jie Yu > >
