> On April 14, 2016, 12:47 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 165-168
> > <https://reviews.apache.org/r/45983/diff/2/?file=1342344#file1342344line165>
> >
> >     Please wrap this with ifdef linux

Thanks for catching this. Wrapped in `#ifdef` and ran the build on OS X to 
confirm.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45983/#review128811
-----------------------------------------------------------


On April 14, 2016, 3:26 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45983/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5130
>     https://issues.apache.org/jira/browse/MESOS-5130
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled the `network/cni` isolator in `MesosContainerizer`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> dfaffd79b807b50c61e1d1a6a0c1b0c99f5df693 
> 
> Diff: https://reviews.apache.org/r/45983/diff/
> 
> 
> Testing
> -------
> 
> make (Ubuntu 14.04 and OS X)
> 
> * Ran the Agent without the `network/cni` enabled in the `--isolation` flags. 
> Without the `--network_cni_plugins_dir` and the `--network_cni_config_dir`, 
> container using a docker image was launched on the host-network. With the 
> `--network_cni_plugins_dir` and the `--network_cni_config_dir` specified the 
> CNI network isolator correctly invoked the specified plugin to given the 
> container its own network namespace.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to