Can you run the tests in a loop (100 iterations) to check for flakiness? @vinodkone
> On Apr 14, 2016, at 8:14 AM, Qian Zhang <zhang...@cn.ibm.com> wrote: > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46204/ > ----------------------------------------------------------- > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Updated slave recovery tests with HTTP command executor. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 > > Diff: https://reviews.apache.org/r/46204/diff/ > > > Testing > ------- > > $ sudo make check GTEST_FILTER="SlaveRecoveryTest*HTTPExecutor" > ... > > [==========] Running 4 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 4 tests from SlaveRecoveryTest/0, where TypeParam = > mesos::internal::slave::MesosContainerizer > [ RUN ] SlaveRecoveryTest/0.ReconnectHTTPExecutor > I0414 23:13:11.715150 1989 executor.cpp:174] Version: 0.29.0 > Received SUBSCRIBED event > Subscribed executor on mesos > Received LAUNCH event > Starting task bf66407c-b780-4bcc-b8de-6d30fe7b2660 > Forked command at 1997 > sh -c 'sleep 1000' > Received ERROR event > Error: Received unexpected '500 Internal Server Error' () for UPDATE > E0414 23:13:11.819635 1994 executor.cpp:663] End-Of-File received from > agent. The agent closed the event stream > Received ERROR event > Error: Received unexpected '400 Bad Request' () for SUBSCRIBE > Received SUBSCRIBED event > Subscribed executor on mesos > Received ACKNOWLEDGED event > Received SHUTDOWN event > Shutting down > Sending SIGTERM to process tree at pid 1997 > [ OK ] SlaveRecoveryTest/0.ReconnectHTTPExecutor (3418 ms) > [ RUN ] SlaveRecoveryTest/0.RecoverUnregisteredHTTPExecutor > I0414 23:13:15.050401 2021 executor.cpp:174] Version: 0.29.0 > Received ERROR event > Error: Received unexpected '500 Internal Server Error' () for SUBSCRIBE > [ OK ] SlaveRecoveryTest/0.RecoverUnregisteredHTTPExecutor (1502 ms) > [ RUN ] SlaveRecoveryTest/0.CleanupHTTPExecutor > I0414 23:13:16.502077 2081 executor.cpp:174] Version: 0.29.0 > Received SUBSCRIBED event > Subscribed executor on mesos > Received LAUNCH event > Starting task 1efe8ac8-d2d5-46d3-99e5-b09cfbab269d > Forked command at 2088 > sh -c 'sleep 1000' > Received ERROR event > Error: Received unexpected '500 Internal Server Error' () for UPDATE > E0414 23:13:16.604841 2080 executor.cpp:663] End-Of-File received from > agent. The agent closed the event stream > Received ERROR event > Error: Received unexpected '400 Bad Request' () for SUBSCRIBE > [ OK ] SlaveRecoveryTest/0.CleanupHTTPExecutor (2348 ms) > [ RUN ] SlaveRecoveryTest/0.KillTaskWithHTTPExecutor > I0414 23:13:18.936816 2130 executor.cpp:174] Version: 0.29.0 > Received SUBSCRIBED event > Subscribed executor on mesos > Received LAUNCH event > Starting task f399801f-0f78-4458-8485-a50a2f082c45 > Forked command at 2133 > sh -c 'sleep 1000' > Received ACKNOWLEDGED event > E0414 23:13:19.176312 2127 executor.cpp:663] End-Of-File received from > agent. The agent closed the event stream > Received ERROR event > Error: Received unexpected '400 Bad Request' () for SUBSCRIBE > Received SUBSCRIBED event > Subscribed executor on mesos > Received KILL event > Received kill for task f399801f-0f78-4458-8485-a50a2f082c45 > Sending SIGTERM to process tree at pid 2133 > Sent SIGTERM to the following process trees: > [ > -+- 2133 sh -c sleep 1000 > --- 2134 sleep 1000 > ] > Command terminated with signal Terminated (pid: 2133) > Received ACKNOWLEDGED event > [ OK ] SlaveRecoveryTest/0.KillTaskWithHTTPExecutor (3725 ms) > [----------] 4 tests from SlaveRecoveryTest/0 (11033 ms total) > > [----------] Global test environment tear-down > [==========] 4 tests from 1 test case ran. (11052 ms total) > [ PASSED ] 4 tests. > > > Thanks, > > Qian Zhang >