----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128938 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (line 60) <https://reviews.apache.org/r/46008/#comment192396> brace on new line 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (lines 79 - 80) <https://reviews.apache.org/r/46008/#comment192388> style 3rdparty/libprocess/3rdparty/stout/tests/main.cpp (line 34) <https://reviews.apache.org/r/46008/#comment192391> Can we use the `EXIT(EXIT_FAILURE) << error_msg;` pattern? 3rdparty/libprocess/3rdparty/stout/tests/main.cpp (line 39) <https://reviews.apache.org/r/46008/#comment192392> Can we call this `teardown_error` so that in the future others won't introduce their own bools? 3rdparty/libprocess/3rdparty/stout/tests/main.cpp (lines 46 - 49) <https://reviews.apache.org/r/46008/#comment192394> I think this comment makes more sense when we introduce the bool `teardown_error`. Otherwise one will ask the question "why don't we just `EXIT` if `wsa_cleanup` fails"? - Joris Van Remoortere On April 14, 2016, 5:21 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46008/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 5:21 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout: Initialize Windows socket stack in Stout tests. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > b5aeab75c2365a3431c397743b95ce7fbd6d7a1a > 3rdparty/libprocess/3rdparty/stout/tests/main.cpp > c449de87bede4d3bf1df368eaf1d22f857c2298f > > Diff: https://reviews.apache.org/r/46008/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
