----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46014/#review128989 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp (lines 43 - 61) <https://reviews.apache.org/r/46014/#comment192449> Do we have plans to implement this in stout? 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp (line 73) <https://reviews.apache.org/r/46014/#comment192447> Can we add a comment here about this similar to below? ``` // NOTE: `getsid` does not have a meaningful interpretation on Windows. ``` 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp (line 121) <https://reviews.apache.org/r/46014/#comment192448> Can we add a comment here about this similar to below? ``` // NOTE: `getsid` does not have a meaningful interpretation on Windows. ``` - Michael Park On April 14, 2016, 2:06 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46014/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 2:06 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4471 > https://issues.apache.org/jira/browse/MESOS-4471 > > > Repository: mesos > > > Description > ------- > > Stout:[1/2] Moved process tests to their own file. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 400c6dc451602926f93b22713af8c66d7ca59ca6 > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > c9d331df2f4496183b5734d2434413f68b9c1b4b > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 9bd34c7508cd813c5de18028956f6a740997c266 > > Diff: https://reviews.apache.org/r/46014/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
