> On April 13, 2016, 2:38 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 168
> > <https://reviews.apache.org/r/44123/diff/2/?file=1338568#file1338568line168>
> >
> >     Do we no longer have a "not implemented" error?

Per our conversation on Slack, we have decided that we never did.


> On April 13, 2016, 2:38 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 86
> > <https://reviews.apache.org/r/44123/diff/2/?file=1338568#file1338568line86>
> >
> >     Is it worth handling the error case here?

Ok, let's do it. In the case that the `FormatMessage` call failed, I choose to 
just output the error code instead of calling `FormatMessage` again, though. It 
can't be turtles _all_ the way down!


> On April 13, 2016, 2:38 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 232
> > <https://reviews.apache.org/r/44123/diff/2/?file=1338568#file1338568line232>
> >
> >     We don't have a X_OK flag in Windows, so we might want to mask that out 
> > before calling `::access`.

Here's my perpective. If we try to call this with `X_OK` we will get a symbol 
undefined error. Also, if someone `#define`s it themselves, masking won't help. 
Also, we have a pattern for dealing with `#define`s, which is usually to 
explicitly not mask out flags that we don't `#define`.

Thoughts?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44123/#review128602
-----------------------------------------------------------


On April 11, 2016, 4:20 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44123/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
> Clemmer, Joris Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: [1/2] Implemented assorted `os::` functions on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/44123/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to