-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46209/#review129038
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp (lines 2370 - 2372)
<https://reviews.apache.org/r/46209/#comment192500>

    ```
    LOG(WARNING) << "Setting 'principal' in FrameworkInfo to '" << 
authenticated[from]
                 << "' because the framework authenticated with that principal 
but did"
                 << " not set it in FrameworkInfo";
    ```


- Vinod Kone


On April 14, 2016, 3:33 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46209/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5214
>     https://issues.apache.org/jira/browse/MESOS-5214
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change explicitly sets `FrameworkInfo.principal` if
> AuthN is enabled for old driver based frameworks. The
> value gets defaulted to the authenticated principal (if missing).
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
> 
> Diff: https://reviews.apache.org/r/46209/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to