----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/#review129098 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/metrics_tests.cpp (line 551) <https://reviews.apache.org/r/46260/#comment192566> Can you please add a test where authentication actually works? (for saftey) - Alexander Rojas On April 15, 2016, 8:58 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46260/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 8:58 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > The test `MetricsTest.SnapshotAuthenticationEnabled` > is added to the libprocess tests in this patch. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/metrics_tests.cpp > b84dc8d858f58bc9f52b218b7153510417cf34c2 > > Diff: https://reviews.apache.org/r/46260/diff/ > > > Testing > ------- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
