----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review129100 -----------------------------------------------------------
src/tests/metrics_tests.cpp (line 288) <https://reviews.apache.org/r/46261/#comment192567> To be consistent with your other patches, could you add tests for wrong credentials. Also, would be nice to have a test where you actually can access the metrics endpoint. src/tests/metrics_tests.cpp (line 317) <https://reviews.apache.org/r/46261/#comment192568> ditto. - Alexander Rojas On April 15, 2016, 9:01 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46261/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 9:01 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > The tests `MetricsTest.AgentAuthenticationEnabled` and > `MetricsTest.MasterAuthenticationEnabled` are added in > this patch. > > > Diffs > ----- > > src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 > > Diff: https://reviews.apache.org/r/46261/diff/ > > > Testing > ------- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
