> On April 15, 2016, 12:03 p.m., Alexander Rojas wrote:
> > src/tests/logging_tests.cpp, line 148
> > <https://reviews.apache.org/r/46262/diff/1/?file=1346283#file1346283line148>
> >
> >     Too keep it consistent, could you add subtests for wrong credentials 
> > and one which succeeds?

Regarding this comment, see my replies in the patches for MetricsTests.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129105
-----------------------------------------------------------


On April 15, 2016, 7:01 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -----
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to