----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129199 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 55) <https://reviews.apache.org/r/46191/#comment192652> Add newline. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 62) <https://reviews.apache.org/r/46191/#comment192653> ``` if (!::GetComputerNameEx(ComputerNameDnsHostname, NULL, &size) && ::GetLastError() != ERROR_MORE_DATA) { ``` 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 66) <https://reviews.apache.org/r/46191/#comment192656> `std::unique_ptr<T>` semantically means that it's pointing to a single element. We should use `std::unique_ptr<T[]>` to use the array of elements version. We should also use `new` so that we don't have to manually calcaluate the number of bytes. ``` std::unique_ptr<char[]> name(new char[size + 1]); ``` 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 333 - 336) <https://reviews.apache.org/r/46191/#comment192659> This fits in one line. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 348) <https://reviews.apache.org/r/46191/#comment192657> `s/computer name/nodename/` 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 349) <https://reviews.apache.org/r/46191/#comment192658> `s/name/nodename/` - Michael Park On April 15, 2016, 8:42 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46191/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 8:42 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4470 > https://issues.apache.org/jira/browse/MESOS-4470 > > > Repository: mesos > > > Description > ------- > > Stout: Implemented `uname` on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > edaa76a5322d0bf60b7172405aa754b5aca95458 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > c48106e5905e3be0faeba7177ef534766089faff > > Diff: https://reviews.apache.org/r/46191/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
