> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! > > Klaus Ma wrote: > LGTM. Just wonder how to handle the input that did not follow our > expectation: > > // value,event,cgroup > // value,unit,event,cgroup > // value,unit,event,cgroup,running,ratio > > fan du wrote: > Any format other than above is invalid :)
No special case for now; but if there's any exception, it's hard for us to find it. Anyway, current patch is OK to me :). - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128117 ----------------------------------------------------------- On April 18, 2016, 1:41 p.m., fan du wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44379/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 1:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4705 > https://issues.apache.org/jira/browse/MESOS-4705 > > > Repository: mesos > > > Description > ------- > > Co-authored with haosdent. > > > Diffs > ----- > > src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 > > Diff: https://reviews.apache.org/r/44379/diff/ > > > Testing > ------- > > 1. {Found and Test} with Serenity, ema filter could get perf event statistics > correctly as expected. > 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* > --log_dir=/tmp/mesos/ > > > Thanks, > > fan du > >
