> On April 18, 2016, 5:03 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 313 > > <https://reviews.apache.org/r/36816/diff/8/?file=1347737#file1347737line313> > > > > What other schemes are we looking to support besides http or not? What > > is the intention of making it a string instead of bool as before?
Let me change to bool. Thank you very much for your review. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review129286 ----------------------------------------------------------- On April 17, 2016, 9:14 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36816/ > ----------------------------------------------------------- > > (Updated April 17, 2016, 9:14 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Michael Park, and > Timothy Chen. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > ------- > > Supported HTTP in Mesos health check program. > > > Diffs > ----- > > include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d > include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c > src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 > src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 > src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb > > Diff: https://reviews.apache.org/r/36816/diff/ > > > Testing > ------- > > * Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and > HealthCheckTest.HealthyTaskNotMatchHttpStatuses > make check > > > Thanks, > > haosdent huang > >
