-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45304/#review129452
-----------------------------------------------------------




src/examples/test_http_executor.cpp (lines 192 - 194)
<https://reviews.apache.org/r/45304/#comment192866>

    Yikes, this case isn't actually unreachable!
    
    Per MESOS-2664 and MESOS-3754, please avoid 'default' in favor of an 
explicit 'case UNKNOWN' so that the compiler helps us catch all switches when 
we introduce a new enum value.
    
    Ditto below.


- Ben Mahler


On March 25, 2016, 9:25 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45304/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5015
>     https://issues.apache.org/jira/browse/MESOS-5015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix changes Call and Event Type enums in executor.proto
> optional for the purpose of backwards compatibility. (MESOS-5015)
> 
> 
> Diffs
> -----
> 
>   CHANGELOG cd551d896e8ba3ec9df17cc477f0abdd87917ab3 
>   include/mesos/executor/executor.proto 
> 6b4141f0aac27be5a4998f16e986fa87a7047834 
>   include/mesos/v1/executor/executor.proto 
> d7b1dd5eec9bcd424c7859d89471148bce8fe16e 
>   src/examples/test_http_executor.cpp 
> 562b0acfd8555b9b773175f53defe0e7e2744641 
>   src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 
>   src/tests/mesos.hpp 23694885a69ddcbc7039de1186093ce0ad5eed22 
> 
> Diff: https://reviews.apache.org/r/45304/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to