> On April 19, 2016, 8:56 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 119-125
> > <https://reviews.apache.org/r/46331/diff/1/?file=1348479#file1348479line119>
> >
> >     I would suggest that we don't save that in Info. This is because 'Info' 
> > struct will be used for recovery as well, and we don't have a way to know 
> > if an orphan container is using command executor or not.
> >     
> >     In fact, this is also true for the above 'rootfs'. We should have just 
> > stored an Option<ContainerConfig>.
> >     
> >     Can you instead just store an Option<ContainerConfig> in Info?

I had the same concern. However, I think `rootfs` is only used when we isolate 
container, it will not be used when we do the cleanup. So I think we do not 
need to restore it as part of `Info` during recovery since we only need to 
recover the information used to do the cleanup, right?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46331/#review129459
-----------------------------------------------------------


On April 19, 2016, 4:21 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46331/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 4:21 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5225
>     https://issues.apache.org/jira/browse/MESOS-5225
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the issue that command executor can not join CNI network.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 6e3fe118fb63d1ce7d5b01a6ac32f8f3a1369cfb 
> 
> Diff: https://reviews.apache.org/r/46331/diff/
> 
> 
> Testing
> -------
> 
> 1. Start master
> sudo ./bin/mesos-master.sh --work_dir=/tmp
> 
> 2. Start agent
> sudo ./bin/mesos-slave.sh --master=192.168.122.171:5050 
> --containerizers=mesos --image_providers=docker 
> --isolation=filesystem/linux,docker/runtime,network/cni 
> --network_cni_config_dir=/opt/cni/net_configs 
> --network_cni_plugins_dir=/opt/cni/plugins
> 
> 3. Launch a command task with mesos-execute, and it will join a CNI network 
> net1.
> sudo src/mesos-execute --master=192.168.122.171:5050 --name=test 
> --docker_image=library/busybox --networks=net1 --command="sleep 10" 
> --shell=true
> I0418 21:34:57.248507 24604 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID 'c992158d-e625-4359-97fe-6320172fd957-0016'
> Submitted task 'test' to agent 'eeb0be14-77cb-462d-b088-657745453c83-S0'
> Received status update TASK_RUNNING for task 'test'
>   source: SOURCE_EXECUTOR
> Received status update TASK_FINISHED for task 'test'
>   message: 'Command exited with status 0'
>   source: SOURCE_EXECUTOR
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to