> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > src/linux/capabilities.cpp, lines 124-125 > > <https://reviews.apache.org/r/46370/diff/1/?file=1350685#file1350685line124> > > > > This should be unnecessary. See: > > https://github.com/klueska-mesosphere/mesos/blob/master/src/linux/cgroups.cpp#L2435
Not sure about this as I like to lean towards good programming practice than depending on compiler flags. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review129674 ----------------------------------------------------------- On April 20, 2016, 8:19 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46370/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 8:19 p.m.) > > > Review request for mesos, Jie Yu and Kevin Klues. > > > Bugs: MESOS-5051 > https://issues.apache.org/jira/browse/MESOS-5051 > > > Repository: mesos > > > Description > ------- > > This change introduces basic API for linux capabilities. This is not a > comprehensive API but is strictly limited to the need for securing Mesos > containers using linux capabilities. > > > Diffs > ----- > > src/CMakeLists.txt 8e3eecb172e6c6b5256313f0937dc19999156e91 > src/Makefile.am 08d5279bbc0c763255fda3c3360d8f24f41bccda > src/linux/capabilities.hpp PRE-CREATION > src/linux/capabilities.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46370/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
