----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/#review129953 -----------------------------------------------------------
Patch looks great! Reviews applied: [46168] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 21, 2016, 5:44 p.m., Michael Browning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46168/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 5:44 p.m.) > > > Review request for mesos, Bernd Mathiske, Jiang Yan Xu, and Zhitao Li. > > > Bugs: MESOS-5119 > https://issues.apache.org/jira/browse/MESOS-5119 > > > Repository: mesos > > > Description > ------- > > Add subdirectory support to URI.filename field. > > URI.filename allows the user to specify the name of the file that will > be saved in the sandbox when the URI is fetched, but previously it would > fail at fetch time if "filename" had a directory component. This change > allows users to specify a relative path for custom filenames within the > sandbox. > > > Diffs > ----- > > CHANGELOG d2e902f8295644c527964123e409be460c2a5789 > docs/fetcher.md fd6d8a78bd35c5644dceff7005dd7dfd9f5f2171 > include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d > include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c > src/launcher/fetcher.cpp 47583eeaed53b3e7ed4db26fee7cdd2fae5e0c9d > src/slave/containerizer/fetcher.hpp > eeb663eac4c86e079228ac806018050d5d039e07 > src/slave/containerizer/fetcher.cpp > d5910ad570371ba54580be5bb94344a1de38d1f9 > src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e > src/tests/fetcher_tests.cpp 23a8dc5f4402c5613744753284aabbe3d09bf797 > > Diff: https://reviews.apache.org/r/46168/diff/ > > > Testing > ------- > > Three tests were added. In fetcher_tests.cpp, CustomFilenameSubdirectory > tests that the fetcher creates a file in a specified subdirectory in the > sandbox, and AbsoluteCustomSubdirectoryFails tests that a custom filename > with an absolute path is rejected. In fetcher_cache_tests.cpp, > CachedCustomFilenameWithSubdirectory tests that the same behavior holds when > the URI is fetched from the cache. > > > Thanks, > > Michael Browning > >
