----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46096/#review129961 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 529) <https://reviews.apache.org/r/46096/#comment193524> We don't need this variable. It's being used only at one location, we can simply do (name == ....) . src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 580) <https://reviews.apache.org/r/46096/#comment193526> Can we do : // In test mode, we will not create a new network namespace for the container. The container will be launched in the host's network namespace. We will use a mock-plugin for the test to return the host's ip address for this test container. - Avinash sridharan On April 12, 2016, 2:45 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46096/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 2:45 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-5167 > https://issues.apache.org/jira/browse/MESOS-5167 > > > Repository: mesos > > > Description > ------- > > Updated prepare() method of "network/cni" isolator for tests. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 159152a01b68a667dbd57fa6452c6c2a3422787c > > Diff: https://reviews.apache.org/r/46096/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
