-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43985/#review130044
-----------------------------------------------------------


Ship it!




Committed with the following changes.


3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp (line 16)
<https://reviews.apache.org/r/43985/#comment193659>

    Remove newline.



3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
<https://reviews.apache.org/r/43985/#comment193660>

    Add newline.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp (line 
51)
<https://reviews.apache.org/r/43985/#comment193661>

    `s/    return SocketError();/  return SocketError();/`



3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 119 - 
121)
<https://reviews.apache.org/r/43985/#comment193662>

    Remove this.


- Michael Park


On April 21, 2016, 6:31 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43985/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [1/4] Implemented `sendfile`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
> cd1bad14919b9d566d5201201d8c3b4a335d5b9f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 
> 293f82f6730551491504721e0af28e9537540db1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
> f3197679a9c22b37acae003262e5c6d21e110f56 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> 750ca6749cb028703ed2fb5dec2aac6c5dabea0d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 3828c53c0dbbf370d642189998af75b9af434e9d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> d634491b301632ce6468f86d04f21fa25afbbaaa 
> 
> Diff: https://reviews.apache.org/r/43985/diff/
> 
> 
> Testing
> -------
> 
> Build Windows,
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to