> On April 20, 2016, 12:26 a.m., Adam B wrote: > > src/tests/cluster.hpp, line 151 > > <https://reviews.apache.org/r/45922/diff/7/?file=1348010#file1348010line151> > > > > Why do you even need the overload for the authorizer here? Seems like > > most tests will either provide --acls and use the default, or set the > > modules/authorizer flags. We can leave this part out until a test needs it. > > Jan Schlicht wrote: > We will need the overload to be able to use mocked authorizers. This will > be important for later authz patches. Of course it is not needed right now, > and I could remove it until a test needs it, on the other hand I think it > should be part of this patch to provide a "ready-to-use" implementation of an > agent authorizer.
Ok, I'm generally against adding things in case we need them later, but I agree that mock authorizers will be useful for testing later patches. Dropping the issue. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review129694 ----------------------------------------------------------- On April 21, 2016, 7:48 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45922/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 7:48 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/configuration.md 86ba66ac62295ca148524bcb2e57fee560ac4ac5 > src/local/local.cpp 7de8a2423185e49dfa849d069938d3243b4f4956 > src/slave/constants.hpp 9978c11fec40055dd42f19c20cd3e9fef4e78cea > src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a > src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315 > src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 > src/slave/slave.hpp f78c1b4e4d5378ef7223c6eb3ea45491c30fb4c1 > src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553 > src/tests/cluster.hpp 96ec52af16776e91200aa755c7847f56e33d71f4 > src/tests/cluster.cpp 3e5fdf6b32a0d99d3ca83743386232d38471e34f > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb > > Diff: https://reviews.apache.org/r/45922/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
