-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45275/#review130125
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp (lines 56 - 65)
<https://reviews.apache.org/r/45275/#comment193787>

    I think what we should do here is:
    
    1) If 'options' is None, we add `--explicitcreate=true`
    
    2) Otherwise, we don't
    
    3) Added a TODO to check dvdcli version


- Jie Yu


On April 22, 2016, 2:29 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45275/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 2:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5251
>     https://issues.apache.org/jira/browse/MESOS-5251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled "--explicitcreate" when call "dvdcli mount".
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> c63fa02b8f13014bbcac6984a49eaa919d26b489 
> 
> Diff: https://reviews.apache.org/r/45275/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to