----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review130196 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp (lines 13 - 40) <https://reviews.apache.org/r/46395/#comment193892> Please leave these in the original order and use the smaller `#ifndef __WINDOWS__` blocks where needed. I think the 3? places necessary are still clean enough to keep the original ordering. 3rdparty/libprocess/src/process.cpp (line 888) <https://reviews.apache.org/r/46395/#comment193893> space between `(char*)` and `&on` - Joris Van Remoortere On April 19, 2016, 4:35 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46395/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 4:35 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3637 > https://issues.apache.org/jira/browse/MESOS-3637 > > > Repository: mesos > > > Description > ------- > > Windows: Removed `std::bind` from `process.cpp` to build on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > d2c458ed93307f75358bb642aaf2ed8e17b2fe97 > > Diff: https://reviews.apache.org/r/46395/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
