----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/#review130180 -----------------------------------------------------------
src/slave/main.cpp (line 232) <https://reviews.apache.org/r/46255/#comment193901> slave->agent? src/tests/main.cpp (lines 34 - 35) <https://reviews.apache.org/r/46255/#comment193865> Alphabetize? src/tests/main.cpp (line 79) <https://reviews.apache.org/r/46255/#comment193904> Why not check the return value here too? - Kapil Arya On April 21, 2016, 4:39 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46255/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 4:39 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4951 > https://issues.apache.org/jira/browse/MESOS-4951 > > > Repository: mesos > > > Description > ------- > > In order to enable authentication on libprocess-level > HTTP endpoints, this patch adds code to the master and > agent's main.cpp file which makes use of the new > `authenticationRealm` argument to `process::initialize` > which allows the authentication realm of such endpoints > to be set when libprocess is initialized. The argument is > added to libprocess initialization in the tests as well. > > > Diffs > ----- > > src/master/main.cpp 7bbc982192b96eed32674070e16575902af80c6d > src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 > src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > > Diff: https://reviews.apache.org/r/46255/diff/ > > > Testing > ------- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
