----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 -----------------------------------------------------------
Fix it, then Ship it! Ship It! 3rdparty/libprocess/include/process/logging.hpp (lines 28 - 31) <https://reviews.apache.org/r/46258/#comment193913> Don't we prefere trailing underscores? 3rdparty/libprocess/include/process/logging.hpp (line 59) <https://reviews.apache.org/r/46258/#comment193911> Just wondering if it makes more sense to have a default 'None()' here and simplify the `initialize` function? - Kapil Arya On April 15, 2016, 2:56 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46258/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 2:56 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > This patch adds authentication to the `/logging/toggle` > HTTP endpoint on the master and agent. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/logging.hpp > 0c0774647d8048a9d8d395141a5864eadc64f8ef > 3rdparty/libprocess/src/logging.cpp > bdbf716ee46a459f1004f0f4b72c23aae135f347 > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46258/diff/ > > > Testing > ------- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
