----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130206 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/metrics.hpp (lines 55 - 58) <https://reviews.apache.org/r/46259/#comment193914> trailing underscore? 3rdparty/libprocess/include/process/metrics/metrics.hpp (line 67) <https://reviews.apache.org/r/46259/#comment193916> Any reason for not making it 'None()' by default to simplify the call site. - Kapil Arya On April 15, 2016, 2:57 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46259/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 2:57 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > This patch adds authentication to the `/metrics/snapshot` > endpoint on the master and agent. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 7abfadf6d030c52b7e03e773b67c74db6ad5b5df > 3rdparty/libprocess/src/metrics/metrics.cpp > 7677dffed98153bc6276aad492a6815e67740ea3 > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46259/diff/ > > > Testing > ------- > > `sudo make check` on OSX > > > Thanks, > > Greg Mann > >
