-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/#review130436
-----------------------------------------------------------



LGTM modulo the comment. Also, have you done a grep for HAS_GPERFTOOLS to 
ensure that there aren't any leftovers?


3rdparty/libprocess/configure.ac (line 853)
<https://reviews.apache.org/r/46461/#comment194178>

    I am wondering if we should split out this patch into two: one that updates 
bundled version, and second that does the HAS_GPERTOOL->ENABLE_GPERFTOOLS 
transition.


- Kapil Arya


On April 21, 2016, 4:29 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46461/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 4:29 p.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-3319
>     https://issues.apache.org/jira/browse/MESOS-3319
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated gperftools to version 2.5 (libprocess).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 
> 13b03cae44e5e6dcfdec4756b975f425b2ea73cf 
>   3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/versions.am 5506eb3 
>   3rdparty/libprocess/configure.ac d27e46e 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fe 
> 
> Diff: https://reviews.apache.org/r/46461/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to