> On April 26, 2016, 2:40 p.m., Kapil Arya wrote: > > Should we also add another test(s) that sets/unsets the environment > > variable to ensure coverage? We can do that in a separate request.
The difficulty here is that with the current implementation, the environment variable has to be set *before* libprocess gets initialized, so we can't set it dynamically during the tests. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46641/#review130617 ----------------------------------------------------------- On April 25, 2016, 8:47 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46641/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 8:47 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > Added tests for the Profiler to libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 > 3rdparty/libprocess/src/tests/profiler_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46641/diff/ > > > Testing > ------- > > `make check` in each of the following configurations: > * after `../configure` > * after `../configure --enable-perftools && export > LIBPROCESS_ENABLE_PROFILER=0` > * after `../configure --enable-perftools && export > LIBPROCESS_ENABLE_PROFILER=1` > > > Thanks, > > Greg Mann > >
