> On 四月 26, 2016, 7:08 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 2151-2152
> > <https://reviews.apache.org/r/46676/diff/1/?file=1361012#file1361012line2151>
> >
> >     IIUC, when someone does a  `make install` there will be 2 directories 
> > in the installation directory.
> >     
> >     ...../mesos/agent
> >     ...../mesos/slave  (this is a symlink to ../agent)
> >     
> >     In the git repo itself we will still have `include/mesos/slave` 
> > directory? I guess renaming this directory to `incluee/mesos/agent`? is too 
> > much work?
> 
> Kevin Klues wrote:
>     The `include/mesos/slave` directory is decoupled from the actually 
> install directory specified by `agentdir`.  We can decide to change 
> `include/mesos/slave` to `include/mesos/agent` in the future, but it has 
> nothing to do with this installation directory.

If we want to change include/mesos/slave to include/mesos/agent in the future, 
for the files that depend on the headers in include/mesos/slave, we need to 
keep the path, is that ok?


- zhou


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review130664
-----------------------------------------------------------


On 四月 26, 2016, 6:06 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> -----------------------------------------------------------
> 
> (Updated 四月 26, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
>     https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [#MESOS-5230]
> Change the 'make install' includedir name from slave to agent.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> -------
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Reply via email to