> On April 27, 2016, 10:24 a.m., Alexander Rojas wrote: > > src/slave/http.cpp, line 798 > > <https://reviews.apache.org/r/46203/diff/18/?file=1362275#file1362275line798> > > > > This looks like a bad pattern here, you could use instead > > `slave->self().id == pathComponents[0]`. > > > > Remember that `!(p && q) == !p || !q`. It might improve readability in > > this expression.
`!(p && q)` is the more readable option here (compare rev 18 to rev 17), because I'd have to add an additional check if I'd want to do `!p || !q`. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review130731 ----------------------------------------------------------- On April 26, 2016, 8:29 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46203/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 8:29 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/configuration.md 2796a812b72f2089999b1ae2d65a4ba843b50d70 > include/mesos/authorizer/acls.proto > c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 > include/mesos/authorizer/authorizer.proto > 40d93ea257d1df8d22eee8a21667db90d579a8fe > src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca > src/authorizer/local/authorizer.cpp > 0a3805fe4ce8eb89e096e8cd4326035513ba892b > src/slave/flags.cpp a319d60c006d1104836c1c40f3617ceac9cb7b1e > src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e > src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46203/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
