----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46723/#review130823 -----------------------------------------------------------
src/master/master.cpp (lines 2078 - 2093) <https://reviews.apache.org/r/46723/#comment194725> Do we want to do this when the frameork sends a message or right after we detect a disconnection in `exited()`? I'm mainly thinking about scenarios where a framework is not sending any messages but is waiting for offers indefinitely. I think it should be safe because the scheduler PID is unique. src/master/master.cpp (line 2082) <https://reviews.apache.org/r/46723/#comment194723> s/making it abort/causing the scheduler driver to abort/ src/master/master.cpp (line 2084) <https://reviews.apache.org/r/46723/#comment194724> s/is not connected/disconnected/ - Vinod Kone On April 27, 2016, 4:57 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46723/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 4:57 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5181 > https://issues.apache.org/jira/browse/MESOS-5181 > > > Repository: mesos > > > Description > ------- > > This change adds logic to send the framework an error message > if the master receives a call from the framework after it has > disconnected. Since driver based frameworks don't receive > heartbeats from the master. There is no way for them to detect > this unless a new master is detected that eventually triggers > re-registration. > > > Diffs > ----- > > src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d > > Diff: https://reviews.apache.org/r/46723/diff/ > > > Testing > ------- > > Added test in r46724 > > > Thanks, > > Anand Mazumdar > >
