-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/#review130852
-----------------------------------------------------------




3rdparty/libprocess/src/subprocess_windows.cpp (line 348)
<https://reviews.apache.org/r/46608/#comment194756>

    This is not requered in the current codebase.



3rdparty/libprocess/src/subprocess_windows.cpp (line 606)
<https://reviews.apache.org/r/46608/#comment194759>

    Since the process is not in suspended there is no need to resume here.



3rdparty/libprocess/src/subprocess_windows.cpp (line 607)
<https://reviews.apache.org/r/46608/#comment194760>

    The handle for the thread can be closed in the createChildProcess()


- Daniel Pravat


On April 23, 2016, 11:41 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46608/
> -----------------------------------------------------------
> 
> (Updated April 23, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
>     https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: Implemented `subprocess_windows.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to