> On April 27, 2016, 7:41 p.m., Ben Mahler wrote:
> > src/linux/cgroups.cpp, line 29
> > <https://reviews.apache.org/r/46730/diff/2/?file=1363198#file1363198line29>
> >
> >     Hm.. where is this header located?
> >     
> >     I'd expect to find a unistd.h here:
> >     https://github.com/apache/mesos/tree/master/src/linux
> 
> Bing Li wrote:
>     I think usually you can find it in /usr/include/linux/ if you have the 
> package like "kernel-devel" installed.

For CentOS, it comes from `kernel-headers`.
```
$ rpm -qf /usr/include/linux/unistd.h
kernel-headers-3.10.0-327.13.1.el7.x86_64
yum install -y kernel-headers
```

For Ubuntu, it comes from `linux-libc-dev`.
```
dpkg -S /usr/include/linux/unistd.h
linux-libc-dev: /usr/include/linux/unistd.h
apt-get install -y linux-libc-dev
```

Should we document this?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review130831
-----------------------------------------------------------


On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
>     https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `<linux/unistd.h>` and removed uncessary condition complie.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
>   src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to