----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review131062 -----------------------------------------------------------
src/master/http.cpp (line 868) <https://reviews.apache.org/r/46784/#comment195014> Could you make this capture list explicit (`[this, request]`)? src/master/http.cpp (line 874) <https://reviews.apache.org/r/46784/#comment195015> Not your pattern and a general problem here, but this does not return any useful response should we fail to get an answer from the `authorizer` :( src/tests/master_authorization_tests.cpp (line 1024) <https://reviews.apache.org/r/46784/#comment195016> This looks very similar to the `SlaveEndpointTest` suite ;) Should we just also make this parameterized from the start? src/tests/master_authorization_tests.cpp (line 1027) <https://reviews.apache.org/r/46784/#comment195019> `s/agent/master/` src/tests/master_authorization_tests.cpp (lines 1054 - 1057) <https://reviews.apache.org/r/46784/#comment195018> Once you have parameterized the fixture on the endpoint you should `s/Slave/Master/`. Before that it doesn't really fit. src/tests/master_authorization_tests.cpp (line 1067) <https://reviews.apache.org/r/46784/#comment195017> `s/agent/master/` - Benjamin Bannier On April 28, 2016, 4:57 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46784/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 4:57 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-5297 > https://issues.apache.org/jira/browse/MESOS-5297 > > > Repository: mesos > > > Description > ------- > > Access to the '/flags' endpoint is authorized using > the 'GET_ENDPOINT_WITH_PATH' action. > > > Diffs > ----- > > src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > > Diff: https://reviews.apache.org/r/46784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
