-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review131089
-----------------------------------------------------------




docs/endpoints/master/quota.md (line 29)
<https://reviews.apache.org/r/46736/#comment195034>

    I would rephrase this. As written, it sounds to me like the _endpoint_ is 
what grants "certain principals" the ability "to set quota for certain roles". 
I would instead say something like: "Using this endpoint to set a quota for a 
certain role requires that the current principal has the `set_quotas` ACL for 
that role. Similarly, using this endpoint to remove a quota..."


- Neil Conway


On April 29, 2016, 9:40 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 9:40 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6 
>   src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a 
> 
> Diff: https://reviews.apache.org/r/46736/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX) and re-generated endpoint documentation.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to