> On May 1, 2016, 5:53 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1082
> > <https://reviews.apache.org/r/46873/diff/1/?file=1368125#file1368125line1082>
> >
> >     One issue is that some tasks without rootfs but with volume or network 
> > info may also have container info, for such tasks, I think that we should 
> > not mark the sandbox as /mnt/mesos/sandbox but still use `directory`?
> >     
> >     
> > https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L530-L575 
> >     
> >     BTW: Can you please make your patch depend on 
> > https://reviews.apache.org/r/46807
> 
> Shuai Lin wrote:
>     Thanks, I just added 46807 as a dependency of this one.
>     
>     - IIRC `ContainerInfo.NetworkInfo` only works for docker containerzier 
> and is skipped by mesos containerizer
>     - Can a task have volumes when it doesn't have a rootfs?

When rebasing on top of #46807, I changed to use `provisionInfo` to determine 
the value of `MESOS_SANDBOX`, please see the latest diff.


- Shuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46873/#review131260
-----------------------------------------------------------


On May 1, 2016, 9:54 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46873/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed MESOS_SANDBOX env in unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8d53895 
> 
> Diff: https://reviews.apache.org/r/46873/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + gcc 4.8.4)
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to