> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? > > Neil Conway wrote: > Seems reasonable to me, but I'd prefer to do this as a separate patch. > > Alexander Rukletsov wrote: > Could you please create a JIRA for that? Or in case we already have one, > post a link here? Thanks!
Link to JIRA: https://issues.apache.org/jira/browse/MESOS-5315 - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131066 ----------------------------------------------------------- On April 29, 2016, 2:08 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46827/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 2:08 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Also removed some unused header includes. > > > Diffs > ----- > > src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 > > Diff: https://reviews.apache.org/r/46827/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
