----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46504/ -----------------------------------------------------------
(Updated May 3, 2016, 12:20 a.m.) Review request for mesos and Alexander Rukletsov. Changes ------- Addressed issues, nested MethodNotAllowedBody inside MethodNotAllowed. Bugs: MESOS-4126 https://issues.apache.org/jira/browse/MESOS-4126 Repository: mesos Description (updated) ------- Constructed error string in MethodNotAllowed. - Decided to use constructor delegation rather than just constructing in MethodNotAllowed allowing body to be constructed before calling the Response constructor. This in addition to the improved readability and sectioning off the verbose body construction as a middle step in a delegation chain led me to this implementation. Noting here that construction in MethodNotAllowed would be completely valid, but seeing what others think of this choice. Diffs (updated) ----- 3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 Diff: https://reviews.apache.org/r/46504/diff/ Testing (updated) ------- make check Thanks, Jacob Janco