----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131485 -----------------------------------------------------------
src/master/master.hpp (line 937) <https://reviews.apache.org/r/46923/#comment195491> The preceding comment ("Inner class used to namespace the handling of quota requests...") refers to the `QuotaHandler` code below -- you should move this function up before the comment. src/master/master.cpp (line 2255) <https://reviews.apache.org/r/46923/#comment195492> Indented too far to the right (two spaces per indent level is Mesos style). I'd use "failover_timeout", rather than "failover timeout". Should we include the framework-provided timeout value in the error message? I'd think probably. src/master/master.cpp (line 2476) <https://reviews.apache.org/r/46923/#comment195493> We probably want to check `validationError.isNone()` here. src/master/master.cpp (line 7342) <https://reviews.apache.org/r/46923/#comment195496> Whitespace. src/tests/master_tests.cpp (line 4481) <https://reviews.apache.org/r/46923/#comment195495> Can we add a comment describing why this failover_timeout is invalid? - Neil Conway On May 3, 2016, 3:31 a.m., Jose Guilherme Vanz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46923/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 3:31 a.m.) > > > Review request for mesos, Kevin Sweeney and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Frameworks were allowed to subscribe themselves with invalid failover > timeout. For this reason, a validation has been made in the master to > deny framework subscription if it set a invalid value for the failover > timeout. MESOS-1575 > > > Diffs > ----- > > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e > src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad > > Diff: https://reviews.apache.org/r/46923/diff/ > > > Testing > ------- > > > Thanks, > > Jose Guilherme Vanz > >
