> On April 14, 2016, 11:33 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp, line 95 > > <https://reviews.apache.org/r/46165/diff/1/?file=1343085#file1343085line95> > > > > This one is subtle as in principle we could use a moved-from > > `FOREACH_ELEM`. This happens for cases where the `begin_expr` returns an > > rvalue in violation of general iterator requirements (e.g., that the result > > of `*it` is assignable). > > > > Could you explain why we'd need to `forward` here and above in the > > first place? I appears we should be able to just `get` directly from the > > `FOREACH_ELEM` in scope.
Dropping this one as we wouldn't actually `move` here, but just potentially cast to an rvalue. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review128851 ----------------------------------------------------------- On April 13, 2016, 11:58 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46165/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 11:58 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and > Joris Van Remoortere. > > > Bugs: MESOS-3214 > https://issues.apache.org/jira/browse/MESOS-3214 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp > 7fb0044790ee249b69e07b81a26851bd5bfb110f > > Diff: https://reviews.apache.org/r/46165/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
