----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46945/#review131553 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On May 3, 2016, 10:34 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46945/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 10:34 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and > Joris Van Remoortere. > > > Bugs: MESOS-3214 > https://issues.apache.org/jira/browse/MESOS-3214 > > > Repository: mesos > > > Description > ------- > > The `value` variable declared in the `foreach` shadows the `value` function > parameter. This seemed to have been ok with the `FOREACH` macro, but this is > no longer ok with `range-based for`. > This seems to be the only place of violation of this. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > d1f4ae6a1d1e6ccfe55f9f8f78390826dc97d894 > > Diff: https://reviews.apache.org/r/46945/diff/ > > > Testing > ------- > > `make check` on Ubuntu 14.04 with GCC 4.8 > > > Thanks, > > Michael Park > >
