-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review131557
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/persistent_volume_tests.cpp (line 68)
<https://reviews.apache.org/r/41613/#comment195590>

    Perhaps we should consider pulling this out to `src/tests/mesos.hpp`.



src/tests/persistent_volume_tests.cpp (lines 573 - 575)
<https://reviews.apache.org/r/41613/#comment195576>

    ```cpp
      Resources taskResources =
          Resources::parse("cpus:1;mem:128;disk(" + DEFAULT_ROLE + 
"):32").get() +
          volume;
    ```



src/tests/persistent_volume_tests.cpp (lines 682 - 684)
<https://reviews.apache.org/r/41613/#comment195577>

    Same as above.


- Michael Park


On Jan. 5, 2016, 2:49 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 2:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `DEFAULT_ROLE` constant to persistent volume tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to