----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131935 -----------------------------------------------------------
3rdparty/libprocess/include/process/windows/subprocess.hpp (line 59) <https://reviews.apache.org/r/46608/#comment195982> In `posix/subprocess.hpp`, we check for `>= 0` because we have `int` and `getOrElse(-1)`. Here we have `HANDLE` and `getOrElse(INVALID_HANDLE_VALUE)`. Is `>= 0` still the appropriate check? 3rdparty/libprocess/src/io.cpp (lines 291 - 294) <https://reviews.apache.org/r/46608/#comment195980> So for some reason `lambda::bind(&os::close, fd)` doesn't work? Do we know anything beyond "MSVC's `std::bind` is crippled"? I think we could just do: ```cpp promise->future().onAny([fd]() { os::close(fd); }); ``` Here and below. - Michael Park On May 5, 2016, 3:12 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46608/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 3:12 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3637 > https://issues.apache.org/jira/browse/MESOS-3637 > > > Repository: mesos > > > Description > ------- > > Libprocess: Implemented `subprocess_windows.cpp`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION > 3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION > 3rdparty/libprocess/src/io.cpp 83e5f04f246b46880cfc34aa56441046b569b142 > 3rdparty/libprocess/src/subprocess.cpp > bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 > 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46608/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
