-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/#review132032
-----------------------------------------------------------



Hi, @lichenn. Thanks a lot for your patch! Here are some my comments for this, 
free feel to drop them if you think them don't make sense.

1. Seems missing update tables in browse.html
2. Because we prefer keep the length of code in 80 characters, I suggest to 
start summary attribute in a new line.
For example,
```
    <table m-table table-content="framework.tasks" title="Active Tasks"
      class="table table-striped table-bordered table-condensed"
      summary="xxx">
```

3. I guest to use Mesos instead of mesos in summary because `Mesos` looks more 
popular in this case.

```
$ cd docs
grep -cr 'Mesos' .|cut -d':' -f2|paste -sd+ - | bc
792
$ grep -cr 'mesos' .|cut -d':' -f2|paste -sd+ - | bc
370 # Most of them are comes from code like `from mesos.native import 
MesosExecutorDrive`


src/webui/master/static/framework.html (line 95)
<https://reviews.apache.org/r/46964/#comment196087>

    Should be completed tasks here?



src/webui/master/static/frameworks.html (line 62)
<https://reviews.apache.org/r/46964/#comment196089>

    Should be completed frameworks or terminated frameworks here?



src/webui/master/static/home.html (line 144)
<https://reviews.apache.org/r/46964/#comment196079>

    Do we need update these table elements?
    
    ```
    <h4>Slaves</h4>
      <table class="table table-condensed">
      
    <h4>Tasks</h4>
      <table class="table table-condensed">
    
    <h4>Resources</h4>
       <table class="table table-condensed">
    ``



src/webui/master/static/slave.html (line 48)
<https://reviews.apache.org/r/46964/#comment196080>

    Do we need update here?



src/webui/master/static/slave.html (line 86)
<https://reviews.apache.org/r/46964/#comment196081>

    Do we need update here?



src/webui/master/static/slave.html (line 126)
<https://reviews.apache.org/r/46964/#comment196091>

    Should be `have running tasks`?



src/webui/master/static/slave_executor.html (line 55)
<https://reviews.apache.org/r/46964/#comment196082>

    Do we need update here?



src/webui/master/static/slave_executor.html (line 126)
<https://reviews.apache.org/r/46964/#comment196092>

    Actually here only show `running tasks`.



src/webui/master/static/slave_framework.html (line 34)
<https://reviews.apache.org/r/46964/#comment196083>

    Do we need update here?



src/webui/master/static/slave_framework.html (line 80)
<https://reviews.apache.org/r/46964/#comment196093>

    s/the current running/the running/g


- haosdent huang


On May 6, 2016, 8:56 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46964/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
>     https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using the summary attribute of the table element.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html 
> 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/offers.html 
> ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 
> 99b23ed9e85011a66bad780fb2d3076e946821a6 
>   src/webui/master/static/slave_framework.html 
> 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
>   src/webui/master/static/slaves.html 
> 063031771cef8b9f45723869198bad3460591936 
> 
> Diff: https://reviews.apache.org/r/46964/diff/
> 
> 
> Testing
> -------
> 
> Have checked with the patch by firebug, each table should have summary 
> attribute.
> 
> For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Reply via email to