> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 22
> > <https://reviews.apache.org/r/46965/diff/1/?file=1370619#file1370619line22>
> >
> >     +1 For use `banner` :-)

Use `banner` is more boostrap style.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
-----------------------------------------------------------


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> -------
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Reply via email to