> On May 6, 2016, 3:37 a.m., Adam B wrote: > > Please create a JIRA with motivation for this hook. I don't want a new hook > > to slip into a release without a JIRA in the changelog to document it.
Good point. I meant to add it to the RR, but it slipped :-). - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131997 ----------------------------------------------------------- On May 5, 2016, 12:01 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46920/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 12:01 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to > inspect the contents of a task and potentially reject the task with a > `TASK_ERROR`. > > > Diffs > ----- > > include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca > src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 > src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 > src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 > src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 > src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 > > Diff: https://reviews.apache.org/r/46920/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >