-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132192
-----------------------------------------------------------




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)
<https://reviews.apache.org/r/47095/#comment196360>

    What about 
    
    s/docker/appc images/rootfs ?
    
    The OCI and other image spec may be introduced later, using `rootfs` may be 
more accurate?



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1107)
<https://reviews.apache.org/r/47095/#comment196358>

    s/normal tasks/tasks without rootfs



src/tests/containerizer/provisioner_docker_tests.cpp (line 559)
<https://reviews.apache.org/r/47095/#comment196357>

    s/MESOS_SANDBOX/`MESOS_SANDBOX`



src/tests/containerizer/provisioner_docker_tests.cpp (line 644)
<https://reviews.apache.org/r/47095/#comment196356>

    s/MESOS_SANDBOX/`MESOS_SANDBOX`


- Guangya Liu


On 五月 8, 2016, 11:47 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> -----------------------------------------------------------
> 
> (Updated 五月 8, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
>     https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> -------
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to