----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36385/#review132194 -----------------------------------------------------------
Patch looks great! Reviews applied: [36385] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 8, 2016, 10:24 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36385/ > ----------------------------------------------------------- > > (Updated May 8, 2016, 10:24 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4896 > https://issues.apache.org/jira/browse/MESOS-4896 > > > Repository: mesos > > > Description > ------- > > Enabled `docker/runtime` isolator dynamically. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 75e5a32a3e70ec60a6800e21a621673184ea0956 > src/slave/containerizer/mesos/provisioner/store.cpp > 7141d63fcf2dbc3fbf00508c7f92945aab014fb2 > > Diff: https://reviews.apache.org/r/36385/diff/ > > > Testing > ------- > > make > make check > > GLOG_v=1 ./bin/mesos-slave.sh --master=10.0.0.65:5050 > --isolation=docker/volume,filesystem/linux --image_providers=docker > --work_dir=/tmp/mesos --launcher=linux --executor_environment_variables="{}" > > Start up a container with docker image using mesos-execute. > > > Thanks, > > Guangya Liu > >